Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update es-mdj.json (implements #558) #561

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Update es-mdj.json (implements #558) #561

merged 5 commits into from
Jan 24, 2024

Conversation

siwhitehouse
Copy link
Contributor

Updated URLs as previous pages were moved without a redirect

Updated URLs as previous pages were moved without a redirect
@siwhitehouse siwhitehouse mentioned this pull request Jan 12, 2024
@siwhitehouse siwhitehouse self-assigned this Jan 12, 2024
@siwhitehouse siwhitehouse changed the title Update es-mdj.json Update es-mdj.json (implements #558) Jan 12, 2024
Copy link
Contributor

@kd-ods kd-ods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like this url http://www.mjusticia.gob.es/cs/Satellite/Portal/es/areas-tematicas/registros (which appears a few times in the entry) has been updated.

Also, the value for name.local is given as "es" whereas it should be "Ministerio de Justicia" and name.en should be "Ministry of Justice, Spain".

Could you please update the lastUpdated field too?

@siwhitehouse
Copy link
Contributor Author

It doesn't look like this url http://www.mjusticia.gob.es/cs/Satellite/Portal/es/areas-tematicas/registros (which appears a few times in the entry) has been updated.

Also, the value for name.local is given as "es" whereas it should be "Ministerio de Justicia" and name.en should be "Ministry of Justice, Spain".

Could you please update the lastUpdated field too?

It doesn't look as though I have included any updates to the record!

Making changes that were missed previously
Copy link
Contributor

@kd-ods kd-ods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggested edits. Otherwise this looks ready to go.

lists/es/es-mdj.json Outdated Show resolved Hide resolved
lists/es/es-mdj.json Outdated Show resolved Hide resolved
@siwhitehouse
Copy link
Contributor Author

@kd-ods Thank you - I've committed those two suggestions.

Copy link
Contributor

@kd-ods kd-ods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I'll merge and update the front-end.

@kd-ods kd-ods merged commit e30ef48 into main Jan 24, 2024
4 of 6 checks passed
@kd-ods kd-ods deleted the siwhitehouse-es-mdj branch January 24, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants